1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
//! Driver for the PS/2 interface, which supports legacy keyboard and mouse devices.
//!
//! The [`init()`] function sets up the single system-wide [`PS2Controller`],
//! which can then be used to obtain a reference to a [`PS2Keyboard`] or [`PS2Mouse`].

#![no_std]

use log::{debug, warn};
use modular_bitfield::{specifiers::{B1, B4, B8}, bitfield, BitfieldSpecifier};
use num_enum::TryFromPrimitive;
use port_io::Port;
use spin::{Mutex, Once};
use fadt::Fadt;

use HostToControllerCommand::*;
use HostToKeyboardCommand::*;
use HostToMouseCommand::*;
use DeviceToHostResponse::*;


/// The system-wide singleton PS/2 Controller.
static PS2_CONTROLLER: Once<PS2Controller> = Once::new();


/// Initializes the PS/2 controller, and the first and second PS/2 ports (if they exist).
///
/// We roughly follow the procedure from the [OS dev wiki].
///
/// [OS dev wiki]: https://wiki.osdev.org/%228042%22_PS/2_Controller#Initialising_the_PS.2F2_Controller
pub fn init() -> Result<&'static PS2Controller, &'static str> {
    if PS2_CONTROLLER.is_completed() {
        return Err("The PS/2 Controller has already been initialized once.");
    }

    // Step 1: Initialise USB Controllers
    // no USB support yet

    // Step 2: Determine if the PS/2 Controller Exists.
    // If ACPI, and therefore the FADT, is unsupported, the PS/2 controller is assumed to exist.
    let acpi_tables = acpi::get_acpi_tables().lock();
    if let Some(fadt) = Fadt::get(&acpi_tables) {
        // If earlier than ACPI v2, the PS/2 controller is assumed to exist
        if fadt.header.revision > 1 {
            let has_controller = fadt.iapc_boot_architecture_flags & 0b10 == 0b10;
            if !has_controller {
                // Since some hardware doesn't seem to care about conforming to ACPI, only warn
                warn!("no PS/2 Controller (8042 bit) present in FADT");
            }
        }
    }

    // Here: the PS/2 Controller exists, so create the object representing it.
    let mut controller = PS2Controller {
        data_port: Mutex::new(Port::new(PS2Controller::PS2_DATA_PORT)),
        command_and_status_port: Mutex::new(Port::new(
            PS2Controller::PS2_COMMAND_AND_STATUS_PORT
        )),
        keyboard_attached: false,
        mouse_attached: false,
    };

    // Step 3: Disable Devices
    controller.write_command(DisablePort1);
    controller.write_command(DisablePort2);

    // Step 4: Flush The Output Buffer
    controller.flush_output_buffer();

    // Step 5: Set the Controller Configuration Byte
    let mut config = controller.read_config();
    config.set_port1_interrupt_enabled(false);
    config.set_port2_interrupt_enabled(false);
    config.set_port1_scancode_translation_enabled(false);
    let has_mouse = config.port2_clock_disabled();
    controller.write_config(config);

    // Step 6: Perform Controller Self Test
    controller.test()?;
    debug!("passed PS/2 controller test");
    // as this can reset the controller on some hardware, we restore the config
    controller.write_config(config);

    // Step 7: Determine If There Are 2 Channels
    // not needed, already done above

    // Step 8: Perform Interface Tests
    let port_1_works = controller.test_port1().is_ok();
    let port_2_works = if has_mouse {
        controller.test_port2().is_ok()
    } else {
        warn!("PS/2 controller is not dual channel, so no mouse available");
        false
    };
    if !port_1_works && !port_2_works {
        return Err("failed both PS/2 port tests, terminating PS/2 controller driver");
    }

    // Step 9: Enable Devices
    if port_1_works {
        debug!("passed PS/2 port 1 test");
        controller.write_command(EnablePort1);
        config.set_port1_clock_disabled(false);
        config.set_port1_interrupt_enabled(true);
    }
    if port_2_works {
        debug!("passed PS/2 port 2 test");
        controller.write_command(EnablePort2);
        config.set_port2_clock_disabled(false);
        config.set_port2_interrupt_enabled(true);
    }
    controller.write_config(config);

    // Step 10: Reset Devices
    let keyboard_ref = PS2Keyboard::new(&controller);
    if let Err(e) = keyboard_ref.reset() {
        warn!("couldn't reset the keyboard; assuming there is none: {e}");
    } else {
        controller.keyboard_attached = true;
    }
    let mouse_ref = PS2Mouse::new(&controller);
    if let Err(e) = mouse_ref.reset() {
        warn!("couldn't reset the mouse; assuming there is none: {e}");
    } else {
        controller.mouse_attached = true;
    }

    debug!("Final PS/2 {:?}", controller.read_config());
    
    Ok(PS2_CONTROLLER.call_once(|| controller))
}

/// An initialized PS/2 controller that can be used to communicate with
/// legacy PS/2 keyboard and mouse devices.
pub struct PS2Controller {
    /// at 0x60
    data_port: Mutex<Port<u8>>,
    /// at 0x64
    command_and_status_port: Mutex<Port<u8>>,
    /// whether a keyboard could be successfully detected
    keyboard_attached: bool,
    /// whether a mouse could be successfully detected
    mouse_attached: bool,
}

impl PS2Controller {
    /// Port used to transmit data to and from the PS/2 Controller and its devices.
    const PS2_DATA_PORT: u16 = 0x60;
    /// Port used to send commands to and receive status from the PS/2 Controller.
    const PS2_COMMAND_AND_STATUS_PORT: u16 = 0x64;

    /// Returns a reference to the keyboard attached to this PS/2 controller.
    ///
    /// The keyboard only uses the data port.
    pub fn keyboard_ref(&self) -> Option<PS2Keyboard> {
        self.keyboard_attached.then_some(PS2Keyboard::new(self))
    }

    /// Returns a reference to the mouse attached to this PS/2 controller.
    ///
    /// The mouse uses both the data port and the command/status port.
    pub fn mouse_ref(&self) -> Option<PS2Mouse> {
        self.mouse_attached.then_some(PS2Mouse::new(self))
    }

    /// Writes a command to the PS/2 command port.
    ///
    /// ## Usage Note
    /// Devices attached to the controller should be disabled *before* writing
    /// a command that returns data, otherwise the output buffer may get overwritten.
    pub fn write_command(&self, value: HostToControllerCommand) {
        unsafe {
            self.command_and_status_port.lock().write(value as u8);
        }
    }

    /// Reads and returns the current config value from the PS/2 controller.
    pub fn read_config(&self) -> ControllerConfigurationByte {
        self.write_command(ReadFromInternalRAMByte0);
        ControllerConfigurationByte::from_bytes([self.read_data()])
    }
    
    /// Writes the given config `value` to the PS/2 controller.
    pub fn write_config(&self, value: ControllerConfigurationByte) {
        self.write_command(WriteToInternalRAMByte0);
        self.write_data(WritableData::Configuration(value));
    }

    /// Reads the PS/2 status port.
    pub fn status_register(&self) -> ControllerToHostStatus {
        ControllerToHostStatus::from_bytes([self.command_and_status_port.lock().read()])
    }

    /// Clean the data port output buffer, skipping the [ControllerToHostStatus] `output_buffer_full` check
    pub fn flush_output_buffer(&self) {
        self.read_data();
    }

    pub fn test(&self) -> Result<(), &'static str> {
        self.write_command(TestController);
        self.read_controller_test_result()
    }

    pub fn test_port1(&self) -> Result<(), &'static str> {
        self.write_command(TestPort1);
        self.match_port_test_result().map_err(|e| {
            warn!("failed PS/2 port 1 test: {e}");
            e
        })
    }

    pub fn test_port2(&self) -> Result<(), &'static str> {
        self.write_command(TestPort2);
        self.match_port_test_result().map_err(|e| {
            warn!("failed PS/2 port 2 test: {e}");
            e
        })
    }

    fn match_port_test_result(&self)-> Result<(), &'static str> {
        const VERY_ARBITRARY_TIMEOUT_VALUE: u16 = u16::MAX;
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            if self.status_register().output_buffer_full() {
                use PortTestResult::*;
                match self.read_data().try_into() {
                    Ok(Passed) => return Ok(()),
                    Ok(ClockLineStuckLow)  => warn!("clock line stuck low"),
                    Ok(ClockLineStuckHigh) => warn!("clock line stuck high"),
                    Ok(DataLineStuckLow)   => warn!("data line stuck low"),
                    Ok(DataLineStuckHigh)  => warn!("data line stuck high"),
                    _ => warn!("failed to read port test result"),
                }
            }
        }

        Err("failed PS/2 port test")
    }

    /// must only be called after writing the [TestController] command
    /// otherwise would read bogus data
    pub fn read_controller_test_result(&self) -> Result<(), &'static str> {
        const CONTROLLER_TEST_PASSED: u8 = 0x55;

        const VERY_ARBITRARY_TIMEOUT_VALUE: u16 = u16::MAX;
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            if self.read_data() == CONTROLLER_TEST_PASSED {
                return Ok(())
            }
        }
        
        Err("failed PS/2 controller test")
    }

    /// e.g. https://wiki.osdev.org/PS/2_Mouse#Set_Sample_Rate_Example
    fn polling_send_receive(&self, value: HostToDevice) -> Result<DeviceToHostResponse, &'static str> {
        self.polling_send(value)?;
        self.polling_receive()
    }

    /// https://wiki.osdev.org/%228042%22_PS/2_Controller#Sending_Bytes_To_Device.2Fs
    fn polling_send(&self, value: HostToDevice) -> Result<(), &'static str> {
        const VERY_ARBITRARY_TIMEOUT_VALUE: u8 = u8::MAX;
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            // so that we don't overwrite the previously sent value
            if !self.status_register().input_buffer_full() {
                self.write_data(WritableData::HostToDevice(value));
                return Ok(());
            }
        }
        Err("polling_send timeout value exceeded")
    }

    /// https://wiki.osdev.org/%228042%22_PS/2_Controller#Polling, which still has some _maybe relevant information_:
    /// We might still need to disable one of the devices every time we send so we can read_data reliably.
    /// As it currently works, it might only be a problem for older devices, so I won't overoptimize.
    fn polling_receive(&self) -> Result<DeviceToHostResponse, &'static str> {
        const VERY_ARBITRARY_TIMEOUT_VALUE: u16 = u16::MAX;
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            // so that we only read when data is available
            if self.status_register().output_buffer_full() {
                if let Ok(response) = self.read_data().try_into() {
                    return Ok(response);
                }
            }
        }
        Err("polling_receive timeout value exceeded")
    }

    /// Read data from the PS/2 data port.
    ///
    /// Note: this can be called directly when within a PS/2 device's interrupt handler.
    /// If polling is used (e.g. in a device's init function), [ControllerToHostStatus] `output_buffer_full` needs to be checked first.
    fn read_data(&self) -> u8 {
        self.data_port.lock().read()
    }

    /// For debugging purposes
    #[allow(dead_code)]
    fn log_read(&self) -> u8 {
        let data = self.read_data();
        debug!("ps2 read: {data:x}");
        data
    }

    /// Write data to the PS/2 data port.
    ///
    /// Note: when writing to the PS/2 controller, it might be necessary to check for
    /// [ControllerToHostStatus] `!input_buffer_full` first.
    fn write_data(&self, value: WritableData) {
        unsafe { self.data_port.lock().write(value.into()) };
    }
}

/// A reference to the PS/2 Mouse connected to the PS/2 Controller.
pub struct PS2Mouse<'c> {
    controller: &'c PS2Controller,
    id: MouseId
}

impl<'c> PS2Mouse<'c> {
    /// Create a new reference to the mouse connected to the given PS2 controller.
    ///
    /// The default mouse id of PS/2 is zero.
    pub fn new(controller: &'c PS2Controller) -> Self {
        Self { controller, id: MouseId::Zero }
    }

    /// Reset the mouse.
    pub fn reset(&self) -> Result<(), &'static str> {
        self.command_to_mouse(HostToMouseCommandOrData::MouseCommand(Reset))?;
        const VERY_ARBITRARY_TIMEOUT_VALUE: u32 = u16::MAX as u32 * 3;
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            if let Ok(SelfTestPassed) = self.controller.read_data().try_into() { //not sure if we need to do this here, as command_to_mouse handles it on real hardware at least (same goes for keyboard reset)
                //returns mouse id 0
                self.controller.read_data();
                return Ok(());
            }
        }
        Err("failed to reset mouse")
    }

    /// write command to the mouse and handle the result
    fn command_to_mouse(&self, value: HostToMouseCommandOrData) -> Result<(), &'static str> {
        self.controller.write_command(WriteByteToPort2InputBuffer);
        const RETRIES: u8 = 3;
        for _ in 0 ..= RETRIES {
            return match self.controller.polling_send_receive(HostToDevice::Mouse(value.clone()))? {
                Acknowledge => Ok(()),
                ResendCommand => continue,
                //we should probably handle the response one more level outside, but this suffices for now:
                SelfTestPassed => Ok(()),
                SelfTestFailed1 | SelfTestFailed2 => Err("failed self-test on reset"),
                e => {
                    warn!("wrong response type: {:?}", e);
                    continue;
                }
            };
        }
        Err("mouse doesn't support the command or there has been a hardware failure")
    }

    /// set PS/2 mouse's sampling rate
    fn set_mouse_sampling_rate(&self, value: MouseSampleRate) -> Result<(), &'static str> {
        self.command_to_mouse(HostToMouseCommandOrData::MouseCommand(SampleRate))
            .and_then(|_| self.command_to_mouse(HostToMouseCommandOrData::SampleRate(value)))
            .map_err(|_| "failed to set the mouse sampling rate")
    }

    /// set `self.id` to the highest possible [MouseId] by magic sequence
    pub fn set_mouse_id(&mut self) -> Result<(), &'static str> {
        self.disable_mouse_packet_streaming()?;

        use crate::MouseSampleRate::*;
        
        // Try setting mouse id to three
        for rate in [_200, _100, _80] {
            self.set_mouse_sampling_rate(rate)?;
        }

        match self.mouse_id() {
            Ok(id) => {
                if let MouseId::Three = id {
                    // Try setting mouse id to four
                    for rate in [_200, _200, _80] {
                        self.set_mouse_sampling_rate(rate)?;
                    }
                    // We need to use whatever the hardware returns here, 4 or 3
                    if let Ok(id) = self.mouse_id() {
                        self.id = id
                    }
                } else {
                    assert!(id == MouseId::Zero)
                }
            }
            Err(e) => debug!("Failed to read the PS/2 mouse ID: {e}"),
        }

        debug!("The PS/2 mouse ID is: {:?}", self.id);

        self.enable_mouse_packet_streaming()?;
        Ok(())
    }

    /// get the [MouseId] without disabling packet streaming, since we already do so in set_mouse_id
    fn mouse_id(&self) -> Result<MouseId, &'static str> {
        self.command_to_mouse(HostToMouseCommandOrData::MouseCommand(GetDeviceID))?;
        
        const VERY_ARBITRARY_TIMEOUT_VALUE: u16 = u16::MAX;
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            if self.is_output_buffer_full() {
                if let Ok(id) = self.controller.read_data().try_into() {
                    return Ok(id)
                }
            }
        }

        Err("failed to get mouse id: bad response")
    }

    /// resend the most recent packet again
    #[allow(dead_code)]
    fn mouse_resend(&self) -> Result<(), &'static str> {
        self.command_to_mouse(HostToMouseCommandOrData::MouseCommand(HostToMouseCommand::ResendByte))
            .map_err(|_| "failed to resend mouse request")
    }

    /// enable the packet streaming
    fn enable_mouse_packet_streaming(&self) -> Result<(), &'static str> {
        self.command_to_mouse(HostToMouseCommandOrData::MouseCommand(EnableDataReporting)).map_err(|_| {
            "failed to enable mouse streaming"
        })
    }

    /// disable the packet streaming
    fn disable_mouse_packet_streaming(&self) -> Result<(), &'static str> {
        self.command_to_mouse(HostToMouseCommandOrData::MouseCommand(DisableDataReporting)).map_err(|_| {
            "failed to disable mouse streaming"
        })
    }

    /// set the resolution of the mouse
    #[allow(dead_code)]
    fn mouse_resolution(&self, value: MouseResolution) -> Result<(), &'static str> {
        self.command_to_mouse(HostToMouseCommandOrData::MouseCommand(SetResolution))
            .and_then(|_| self.command_to_mouse(HostToMouseCommandOrData::MouseResolution(value)))
            .map_err(|_| "failed to set the mouse resolution")
    }

    /// read the correct [MousePacket] according to [MouseId]
    pub fn read_mouse_packet(&self) -> MousePacket {
        let read_data = || self.controller.read_data();
        match self.id {
            MouseId::Zero => MousePacket::Zero(
                MousePacketGeneric::from_bytes([
                    read_data(), read_data(), read_data()
                ])
            ),
            MouseId::Three => MousePacket::Three(
                MousePacket3::from_bytes([
                    read_data(), read_data(), read_data(), read_data()
                ])
            ),
            MouseId::Four => MousePacket::Four(
                MousePacket4::from_bytes([
                    read_data(), read_data(), read_data(), read_data()
                ])
            ),
        }
    }

    /// Returns `true` if there is content in the PS/2 Mouse's output buffer
    /// that can be read from.
    /// 
    /// This also checks the status register's `output_buffer_full` bit.
    /// Otherwise `mouse_id` would read ACK (0xFA) instead of mouse id.
    pub fn is_output_buffer_full(&self) -> bool {
        let sr = self.controller.status_register();
        sr.output_buffer_full() && sr.mouse_output_buffer_full()
    }
}

/// A reference to the PS/2 Keyboard connected to the PS/2 Controller.
pub struct PS2Keyboard<'c> {
    controller: &'c PS2Controller,
}

impl<'c> PS2Keyboard<'c> {
    /// Create a new reference to the keyboard connected to the given PS2 controller.
    pub fn new(controller: &'c PS2Controller) -> Self {
        Self { controller }
    }
    
    /// Reset the keyboard.
    pub fn reset(&self) -> Result<(), &'static str> {
        self.command_to_keyboard(HostToKeyboardCommandOrData::KeyboardCommand(ResetAndStartSelfTest))?;
        // VirtualBox and presumably real hardware wants this. Qemu worked without this.
        // Sadly self.controller.polling_receive doesn't work here, either.
        const VERY_ARBITRARY_TIMEOUT_VALUE: u32 = u16::MAX as u32 * 4;
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            if let Ok(SelfTestPassed) = self.controller.read_data().try_into() {
                return Ok(())
            }
        }
        Err("failed to reset keyboard")
    }

    /// write command to the keyboard and handle the result
    fn command_to_keyboard(&self, value: HostToKeyboardCommandOrData) -> Result<(), &'static str> {
        const RETRIES: u8 = 3;
        for _ in 0..=RETRIES {
            return match self.controller.polling_send_receive(HostToDevice::Keyboard(value.clone()))? {
                Acknowledge => Ok(()),
                ResendCommand => continue,
                //we should probably handle the response one more level outside, but this suffices for now:
                SelfTestPassed => Ok(()),
                SelfTestFailed1 | SelfTestFailed2 => Err("failed self-test on reset"),
                e => {
                    warn!("wrong response type: {:?}", e);
                    continue;
                }
            };
        }
        Err("keyboard doesn't support the command or there has been a hardware failure")
    }

    /// Set the status LEDs on the keyboard.
    pub fn set_keyboard_led(&self, value: LEDState) -> Result<(), &'static str> {
        self.command_to_keyboard(HostToKeyboardCommandOrData::KeyboardCommand(SetLEDStatus))
            .and_then(|_| self.command_to_keyboard(HostToKeyboardCommandOrData::LEDState(value)))
            .map_err(|_| "failed to set the keyboard led")
    }

    /// Set the active scancode set currently used by the keyboard.
    /// 
    /// TODO:      set Set2, if Get == 2, return
    ///       else set Set1, if Get == 1, return
    ///       else set Set3, if Get == 3, return
    ///       else Err
    pub fn set_keyboard_scancode_set(&self, value: ScancodeSet) -> Result<(), &'static str> {
        self.command_to_keyboard(HostToKeyboardCommandOrData::KeyboardCommand(ScancodeSet))
            .and_then(|_| self.command_to_keyboard(HostToKeyboardCommandOrData::ScancodeSet(value)))
            .and_then(|_| {
                if self.get_keyboard_scancode_set()? == value {
                    //Note: this does not mean it supports the scancode set,
                    //      it will not interrupt if the set is unsupported
                    debug!("hardware returned the scancode set we've set");
                } else {
                    debug!("failed: hardware didn't return the scancode set we've set");
                }
                Ok(())
            })
            .map_err(|e| {
                warn!("{e}");
                e
            })
    }

    fn get_keyboard_scancode_set(&self) -> Result<ScancodeSet, &'static str> {
        self.command_to_keyboard(HostToKeyboardCommandOrData::KeyboardCommand(ScancodeSet))
        .and_then(|_| self.command_to_keyboard(HostToKeyboardCommandOrData::ScancodeSet(ScancodeSet::Get)))
        .and_then(|_| {
            const VERY_ARBITRARY_TIMEOUT_VALUE: u16 = u16::MAX;
            for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
                if self.is_output_buffer_full() {
                    if let Ok(id) = self.controller.read_data().try_into() {
                        return Ok(id)
                    }
                }
            }
            Err("failed to get scancode set: timeout exceeded")
        })
        .map_err(|e| {
            warn!("{e}");
            e
        })
    }

    /// Detect the [KeyboardType].
    ///
    /// Note:
    /// On the identify command, [KeyboardType::AncientATKeyboard] usually returns no bytes at all, but `PS2Controller::read_data` always returns a byte.
    /// This means `PS2Controller::read_data` would presumably return 0x00 here, even though the value is already reserved for the device type "Standard PS/2 mouse".
    /// As we only care about detecting keyboard types here, it should work.
    pub fn keyboard_detect(&self) -> Result<KeyboardType, &'static str> {
        self.command_to_keyboard(HostToKeyboardCommandOrData::KeyboardCommand(DisableScanning))?;
        self.command_to_keyboard(HostToKeyboardCommandOrData::KeyboardCommand(IdentifyKeyboard))?; 

        let mut keyboard_type = Err("unrecognized keyboard type");
        const VERY_ARBITRARY_TIMEOUT_VALUE: u16 = u16::MAX; //TODO: replace all these loops with an untyped polling_receive?
        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
            if self.is_output_buffer_full() {
                match self.controller.read_data() {
                    0x00 => keyboard_type = Ok(KeyboardType::AncientATKeyboard), //might be wrong
                    0xAB => {
                        //This loop + check might be irrelevant
                        for _ in 0..VERY_ARBITRARY_TIMEOUT_VALUE {
                            if self.is_output_buffer_full() {
                                match self.controller.read_data() {
                                    0x41 | 0xC1 => keyboard_type = Ok(KeyboardType::MF2KeyboardWithPSControllerTranslator),
                                    0x83 => keyboard_type = Ok(KeyboardType::MF2Keyboard),
                                    _ => continue,
                                };
                                break;
                            }
                        }
                    }
                    _ => continue,
                };
                break;
            }
        }
        
        self.command_to_keyboard(HostToKeyboardCommandOrData::KeyboardCommand(EnableScanning))?;
        keyboard_type
    }

    /// Convenience method to see if the keyboard can be polled
    fn is_output_buffer_full(&self) -> bool {
        self.controller.status_register().output_buffer_full()
    }

    /// Reads a raw scancode value from the PS/2 controller's data port.
    pub fn read_scancode(&self) -> u8 {
        self.controller.read_data()
    }
}


// https://wiki.osdev.org/%228042%22_PS/2_Controller#PS.2F2_Controller_Commands
// quite a few of these are commented out because they're either unused, deprecated or non-standard.
/// Commands that can be sent to the PS/2 Controller.
///
/// The naming convention is device-centric:
/// * "Output" means sending data "out of the device to the host (CPU)".
/// * "Input" means sending data "out of the host (CPU) into the device".
///   * Example: [WriteByteToPort2InputBuffer] instructs the host (CPU) to write a byte
///     into port 2 of the device, so the device receives that byte as input.
pub enum HostToControllerCommand {
    /// returns [ControllerConfigurationByte]
    ReadFromInternalRAMByte0 = 0x20,
    
    // return is non-standard
    // /// 0x21-0x3F; N is the command byte & 0x1F
    // ReadFromInternalRAMByteN = 0x21,

    /// sets [ControllerConfigurationByte]
    WriteToInternalRAMByte0 = 0x60,

    // usage is non-standard
    // /// 0x61-0x7F; N is the command byte & 0x1F
    // WriteToInternalRAMByteN = 0x61,

    // these are all deprecated 
    // PasswordInstalledTest = 0xA4,
    // LoadSecurity = 0xA5,
    // EnableSecurity = 0xA6,
    
    /// sets [ControllerConfigurationByte] `port2_clock_disabled`
    ///
    /// Note: only if 2 PS/2 ports supported
    DisablePort2 = 0xA7,
    /// clears [ControllerConfigurationByte] `port2_clock_disabled`
    ///
    /// Note: only if 2 PS/2 ports supported
    EnablePort2 = 0xA8,
    /// returns [PortTestResult]
    ///
    /// Note: only if 2 PS/2 ports supported
    TestPort2 = 0xA9,
    /// see [PS2Controller::test]
    TestController = 0xAA,
    /// returns [PortTestResult]
    TestPort1 = 0xAB,

    // unused
    // /// read all bytes of internal RAM
    // DiagnosticDump = 0xAC,

    /// sets [ControllerConfigurationByte] `port1_clock_disabled`
    DisablePort1 = 0xAD,
    /// clears [ControllerConfigurationByte] `port1_clock_disabled`
    EnablePort1 = 0xAE,

    // return is non-standard
    // ReadControllerInputPort = 0xC0,

    // both unused
    // CopyBits0to3ofInputPortToStatusBits4to7 = 0xC1,
    // CopyBits4to7ofInputPortToStatusBits4to7 = 0xC2,

    // both unused and therefore not implemented, https://wiki.osdev.org/%228042%22_PS/2_Controller#PS.2F2_Controller_Output_Port
    // /// returns [ControllerOutputPort]
    // ReadControllerOutputPort = 0xD0,
    // /// sets [ControllerOutputPort]
    // ///
    // /// Note: Check if the output buffer is empty first
    // WriteByteToControllerOutputPort = 0xD1,

    // both unused
    // /// makes it look like the byte written was received from the first PS/2 port
    // ///
    // /// Note: only if 2 PS/2 ports supported
    // WriteByteToPort1OutputBuffer = 0xD2,
    // /// makes it look like the byte written was received from the second PS/2 port
    // ///
    // /// Note: only if 2 PS/2 ports supported
    // WriteByteToPort2OutputBuffer = 0xD3,

    /// sends next byte to the second PS/2 port
    ///
    /// Note: only if 2 PS/2 ports supported
    WriteByteToPort2InputBuffer = 0xD4,

    // both unused
    // ReadTestInputs = 0xE0,
    // /// 0xF0-0xFF; Bits 0 to 3 correspond to 4 different output lines and are used as a mask:
    // /// 0 = pulse line, 1 = don't pulse line; Bit 0 corresponds to the "reset" line.
    // /// The other output lines don't have a standard/defined purpose.
    // PulseOutputLineLowFor6ms = 0xF0,
}

// see https://wiki.osdev.org/%228042%22_PS/2_Controller#Status_Register
// and https://users.utcluj.ro/~baruch/sie/labor/PS2/PS-2_Keyboard_Interface.htm
#[bitfield(bits = 8)]
pub struct ControllerToHostStatus {
    /// When using [Polling](https://wiki.osdev.org/%228042%22_PS/2_Controller#Polling), must be `true` before attempting to read data from PS/2 data port.
    /// When using [Interrupts](https://wiki.osdev.org/%228042%22_PS/2_Controller#Interrupts), guaranteed to be `true`, because an interrupt only happens if the buffer is full
    /// Alternative name: output_register_full, which might make more sense because it only ever fits 1 byte. "Buffer" sounds like multiple.
    output_buffer_full: bool,
    /// Must be `false` before attempting to write data to PS/2 data port or PS/2 command/status port for 8042 keyboard controller
    /// Alternative name: input_register_full, which might make more sense because it only ever fits 1 byte. "Buffer" sounds like multiple.
    input_buffer_full: bool,
    /// Cleared on reset; set when the system passed Power-on self-test
    #[allow(dead_code)]
    system_passed_self_test: bool,
    /// If `0`, the input buffer should be written to the PS/2 data port.
    /// If `1`, the input buffer should be written to the PS/2 command/status port.
    #[allow(dead_code)]
    input_buffer_is_command: B1,
    /// Whether or not communication is inhibited (via switch) / Unknown (chipset specific) / (more likely unused on modern systems)
    #[allow(dead_code)]
    keyboard_enabled: bool,

    //deprecated (exclusive to AT-compatible mode)
    // /// Keyboard didn't generate clock signals within 15 ms of "request-to-send"
    // transmit_timeout: bool,
    // /// Keyboard didn't generate clock signals within 20 ms of command reception
    // receive_timeout: bool,

    /// Similar to `output_buffer_full`, except for mouse
    pub mouse_output_buffer_full: bool,
    /// Timeout during keyboard command receive or response (Same as `transmit_timeout` + `receive_timeout`)
    #[allow(dead_code)]
    timeout_error: bool,
    /// Should be odd parity, set to `true` if even parity received
    #[allow(dead_code)]
    parity_error: bool,
}

/// Kinds of data that can be written to the PS/2 data port.
enum WritableData {
    Configuration(ControllerConfigurationByte),
    HostToDevice(HostToDevice)
}

impl From<WritableData> for u8 {
    fn from(value: WritableData) -> Self {
        use HostToKeyboardCommandOrData::*;
        use HostToMouseCommandOrData::*;
        match value {
            WritableData::Configuration(value) => u8::from_ne_bytes(value.into_bytes()),
            WritableData::HostToDevice(value) => match value {
                HostToDevice::Keyboard(value) => match value {
                    KeyboardCommand(c) => c as u8,
                    LEDState(l) => u8::from_ne_bytes(l.into_bytes()),
                    ScancodeSet(s) => s as u8,
                }
                HostToDevice::Mouse(value) => match value {
                    MouseCommand(c) => c as u8,
                    MouseResolution(r) => r as u8,
                    SampleRate(s) => s as u8,
                }
            }
        }
    }
}

/// Configuration values used to enable or disable features of the PS/2 controller.
///
/// This type is used with [HostToControllerCommand::ReadFromInternalRAMByte0]
/// and [HostToControllerCommand::WriteToInternalRAMByte0].
///
/// [More info](wiki.osdev.org/%228042%22_PS/2_Controller#PS.2F2_Controller_Configuration_Byte)
#[bitfield(bits = 8)]
#[derive(Debug, Clone, Copy)]
pub struct ControllerConfigurationByte {
    /// interrupt on [ControllerToHostStatus] `output_buffer_full`
    pub port1_interrupt_enabled: bool,
    /// interrupt on [ControllerToHostStatus] `mouse_output_buffer_full`
    ///
    /// Note: only if 2 PS/2 ports supported
    pub port2_interrupt_enabled: bool,
    /// Cleared on reset; set when the system passed Power-on self-test
    #[allow(dead_code)]
    system_passed_self_test: bool,
    // or override_keyboard_inhibiting
    #[allow(dead_code)]
    should_be_zero: B1,
    /// disables the keyboard
    pub port1_clock_disabled: bool,
    /// disables the auxilary device (mouse)
    ///
    /// Note: only if 2 PS/2 ports supported
    pub port2_clock_disabled: bool,
    /// whether IBM scancode translation is enabled (0=AT, 1=PC)
    pub port1_scancode_translation_enabled: bool,
    #[allow(dead_code)]
    must_be_zero: B1,
}

#[derive(TryFromPrimitive)]
#[repr(u8)]
pub enum PortTestResult {
    Passed = 0x00,
    ClockLineStuckLow = 0x01,
    ClockLineStuckHigh = 0x02,
    DataLineStuckLow = 0x03,
    DataLineStuckHigh = 0x04,
}

// https://wiki.osdev.org/PS/2_Keyboard#Special_Bytes all other bytes sent by the keyboard are scan codes
// http://users.utcluj.ro/~baruch/sie/labor/PS2/PS-2_Mouse_Interface.htm mouse only returns AA, FC or FA, mouse_id and packet
#[derive(Debug, TryFromPrimitive)]
#[repr(u8)]
pub enum DeviceToHostResponse {
    KeyDetectionErrorOrInternalBufferOverrun1 = 0x00,
    /// sent after "0xFF (reset)" command or keyboard power up
    SelfTestPassed = 0xAA,
    ResponseToEcho = 0xEE,
    Acknowledge = 0xFA,
    /// sent after "0xFF (reset)" command or keyboard power up
    SelfTestFailed1 = 0xFC,
    /// sent after "0xFF (reset)" command or keyboard power up
    SelfTestFailed2 = 0xFD,
    ResendCommand = 0xFE,
    KeyDetectionErrorOrInternalBufferOverrun2 = 0xFF,
}

#[derive(Debug, Clone)]
enum HostToDevice {
    Keyboard(HostToKeyboardCommandOrData),
    Mouse(HostToMouseCommandOrData)
}

// https://wiki.osdev.org/PS/2_Keyboard#Commands
#[derive(Debug, Clone)]
pub enum HostToKeyboardCommandOrData {
    KeyboardCommand(HostToKeyboardCommand),
    LEDState(LEDState),
    ScancodeSet(ScancodeSet),
    //TODO: Typematic, Scancode
}

#[derive(Debug, Clone)]
pub enum HostToKeyboardCommand {
    SetLEDStatus = 0xED,
    // unused
    // /// for diagnostic purposes and useful for device removal detection
    // Echo = 0xEE,
    ScancodeSet = 0xF0,
    IdentifyKeyboard = 0xF2,
    /// also called typematic
    SetRepeatRateAndDelay = 0xF3,
    EnableScanning = 0xF4,
    /// might also restore default parameters
    DisableScanning = 0xF5,
    // unused
    //SetDefaultParameters = 0xF6,

    // unused and scancode set 3 only
    //SetAllKeysToAutorepeat = 0xF7,
    //SetAllKeysToMakeRelease = 0xF8,
    //SetAllKeysToMake = 0xF9,
    //SetAllKeysToAutorepeatMakeRelease = 0xFA,
    //SetKeyToAutorepeat = 0xFB,
    //SetKeyToMakeRelease = 0xFC,
    //SetKeyToMake = 0xFD,

    ResendByte = 0xFE,
    ResetAndStartSelfTest = 0xFF,
}

#[bitfield(bits = 3)]
#[derive(Debug, Clone)]
pub struct LEDState {
    pub scroll_lock: bool,
    pub number_lock: bool,
    pub caps_lock: bool,
}

// Note: with hardware translation on, these would be:
// Set1 = 0x43, Set2 = 0x41, Set3 = 0x3f
// but we're not using scancode translation.
#[derive(Debug, Clone, Copy, PartialEq, TryFromPrimitive)]
#[repr(u8)]
pub enum ScancodeSet {
    Get = 0,
    Set1 = 1,
    Set2 = 2,
    Set3 = 3,
}

#[derive(Debug, Clone)]
pub enum HostToMouseCommandOrData {
    MouseCommand(HostToMouseCommand),
    SampleRate(MouseSampleRate),
    MouseResolution(MouseResolution),
}

// https://wiki.osdev.org/PS/2_Mouse#Mouse_Device_Over_PS.2F2
// the comments right beside the fields are just there for some intuition on PS/2
#[derive(Debug, Clone)]
pub enum HostToMouseCommand {
    /// either to 1 or 2
    SetScaling = 0xE6,
    /// set [MouseResolution]
    SetResolution = 0xE8,
    StatusRequest = 0xE9,
    SetStreamMode = 0xEA,
    ReadData = 0xEB,
    ResetWrapMode = 0xEC,
    SetWrapMode = 0xEE,
    SetRemoteMode = 0xF0, //same value as SetScancodeSet
    GetDeviceID = 0xF2, //same value as IdentifyKeyboard
    SampleRate = 0xF3,  //same value as SetRepeatRateAndDelay
    EnableDataReporting = 0xF4, //same value as EnableScanning
    DisableDataReporting = 0xF5, //same value as DisableScanning
    SetDefaults = 0xF6, //same
    ResendByte = 0xFE,  //same
    Reset = 0xFF,       //same
}

#[bitfield(bits = 24)]
#[derive(Debug, BitfieldSpecifier)]
pub struct MousePacketGeneric {
    //1. byte starts here
    pub button_left: bool,
    pub button_right: bool,
    pub button_middle: bool,
    pub always_one: B1,
    /// see [x_1st_to_8th_bit]
    x_9th_bit: bool,
    /// see [y_1st_to_8th_bit]
    y_9th_bit: bool,
    x_overflow: bool,
    y_overflow: bool,
    //2. byte
    /// only a part of x_movement, needs to be combined with [x_9th_bit]
    x_1st_to_8th_bit: B8,
    //3. byte
    /// only a part of y_movement, needs to be combined with [y_9th_bit]
    y_1st_to_8th_bit: B8,
}

impl MousePacketGeneric {
    /// `x_1st_to_8th_bit` and `x_9th_bit` should not be accessed directly, because they're part of one signed 9-bit number
    ///
    /// Note: This handles overflow as well, although it might not happen on newer systems <https://forum.osdev.org/viewtopic.php?f=1&t=31176>
    pub fn x_movement(&self) -> i16 {
        let x_1st_to_8th_bit = if self.x_overflow() {
            u8::MAX
        } else {
            self.x_1st_to_8th_bit()
        };
        Self::to_2s_complement(x_1st_to_8th_bit, self.x_9th_bit())
    }

    /// `y_1st_to_8th_bit` and `y_9th_bit` should not be accessed directly, because they're part of one signed 9-bit number
    ///
    /// Note: This handles overflow as well, although it might not happen on newer systems <https://forum.osdev.org/viewtopic.php?f=1&t=31176>
    pub fn y_movement(&self) -> i16 {
        let y_1st_to_8th_bit = if self.y_overflow() {
            u8::MAX
        } else {
            self.y_1st_to_8th_bit()
        };
        Self::to_2s_complement(y_1st_to_8th_bit, self.y_9th_bit())
    }

    // implementation from https://wiki.osdev.org/PS/2_Mouse
    fn to_2s_complement(bit1to8: u8, bit9: bool) -> i16 {
        // to fit a 9th bit inside; we can't just convert to i16, because it would turn e.g. 255 into -1
        let unsigned = bit1to8 as u16; // 1111_1111 as u16 = 0000_0000_1111_1111

        // now convert into i16, which always gives us a positive number
        let signed = unsigned as i16; // 0000_0000_1111_1111 as i16 = 0000_0000_1111_1111
        
        if bit9 {
            // value is negative, produce the two's complement, correctly sign extended no matter its size
            signed - 0b1_0000_0000 // 0000_0000_1111_1111 - 1_0000_0000 = -1
        } else {
            signed
        }
    }
}

#[bitfield(bits = 32)]
#[derive(Debug)]
pub struct MousePacket3 {
    generic_part: MousePacketGeneric,
    //4. byte
    /// already stored in two's complement, valid values are -8 to +7
    z_movement: u8,
}
impl MousePacket3 {
    //TODO: see osdev wiki, might be wrong
    /// often called `z_movement`, renamed to disambiguate
    pub fn scroll_movement(&self) -> i8 {
        self.z_movement() as i8
    }
}

// see https://wiki.osdev.org/PS/2_Mouse#5_buttons
#[bitfield(bits = 32)]
#[derive(Debug)]
pub struct MousePacket4 {
    generic_part: MousePacketGeneric,
    //4. byte starts here
    /// already stored in two's complement
    z_movement: B4,
    pub button_4: bool,
    pub button_5: bool,
    #[allow(dead_code)]
    zero1: B1,
    #[allow(dead_code)]
    zero2: B1,
}
impl MousePacket4 {
    //TODO: see osdev wiki, might be wrong
    /// often called `z_movement`, renamed to disambiguate
    pub fn scroll_movement(&self) -> i8 {
        self.z_movement() as i8
    }
}

#[derive(Debug)]
pub enum MousePacket {
    Zero(MousePacketGeneric),
    Three(MousePacket3),
    Four(MousePacket4)
}

// demultiplexes [MousePacket] and provides standard values
impl MousePacket {
    pub fn button_left(&self) -> bool {
        match self {
            MousePacket::Zero(m) => m.button_left(),
            MousePacket::Three(m) => m.generic_part().button_left(),
            MousePacket::Four(m) => m.generic_part().button_left(),
        }
    }
    pub fn button_right(&self) -> bool {
        match self {
            MousePacket::Zero(m) => m.button_right(),
            MousePacket::Three(m) => m.generic_part().button_right(),
            MousePacket::Four(m) => m.generic_part().button_right(),
        }
    }
    pub fn button_middle(&self) -> bool {
        match self {
            MousePacket::Zero(m) => m.button_middle(),
            MousePacket::Three(m) => m.generic_part().button_middle(),
            MousePacket::Four(m) => m.generic_part().button_middle(),
        }
    }
    pub fn always_one(&self) -> u8 {
        match self {
            MousePacket::Zero(m) => m.always_one(),
            MousePacket::Three(m) => m.generic_part().always_one(),
            MousePacket::Four(m) => m.generic_part().always_one(),
        }
    }
    pub fn x_movement(&self) -> i16 {
        match self {
            MousePacket::Zero(m) => m.x_movement(),
            MousePacket::Three(m) => m.generic_part().x_movement(),
            MousePacket::Four(m) => m.generic_part().x_movement(),
        }
    }
    pub fn y_movement(&self) -> i16 {
        match self {
            MousePacket::Zero(m) => m.y_movement(),
            MousePacket::Three(m) => m.generic_part().y_movement(),
            MousePacket::Four(m) => m.generic_part().y_movement(),
        }
    }
    pub fn scroll_movement(&self) -> i8 {
        match self {
            MousePacket::Three(m) => m.scroll_movement(),
            MousePacket::Four(m) => m.scroll_movement(),
            _ => 0,
        }
    }
    pub fn button_4(&self) -> bool {
        match self {
            MousePacket::Four(m) => m.button_4(),
            _ => false,
        }
    }
    pub fn button_5(&self) -> bool {
        match self {
            MousePacket::Four(m) => m.button_5(),
            _ => false,
        }
    }
}

#[derive(Debug, Clone)]
pub enum MouseSampleRate {
    _10 = 10,
    _20 = 20,
    _40 = 40,
    _60 = 60,
    _80 = 80,
    _100 = 100,
    _200 = 200
}

/// See [MousePacket] and its enum variants for further information.
#[derive(Debug, PartialEq, TryFromPrimitive)]
#[repr(u8)]
pub enum MouseId {
    /// the mouse has no scroll-movement
    Zero = 0,
    /// the mouse has scroll-movement
    Three = 3,
    /// the mouse has scroll-movement, fourth and fifth buttons
    Four = 4,
}

#[derive(Debug, Clone)]
pub enum MouseResolution {
    Count1PerMm = 0,
    Count2PerMm = 1,
    Count4PerMm = 2,
    Count8PerMm = 3
}

// NOTE: could be combined into a PS2DeviceType enum, see https://wiki.osdev.org/%228042%22_PS/2_Controller#Detecting_PS.2F2_Device_Types
pub enum KeyboardType {
    MF2Keyboard,
    MF2KeyboardWithPSControllerTranslator,
    AncientATKeyboard,
}